Ajax-Endpoints: Fatal-Handler + Output-Buffer, mysoc defensiv [deploy]
All checks were successful
Deploy bericht / deploy (push) Successful in 1s

- ajax/_inc.php: ob_start() + register_shutdown_function fangen PHP Notices
  und Fatals auf, geben strukturiertes JSON zurück (vorher Server-Fehler
  'kein JSON' weil PHP-Warning mitten im Body stand).
- generate_pdf.php/preview_pdf.php: mysoc, logo-Pfad defensiv geprüft.
This commit is contained in:
Eduard Wisch 2026-04-09 15:50:36 +02:00
parent d5b89747be
commit 3a7ed278e5
3 changed files with 39 additions and 4 deletions

View file

@ -20,8 +20,13 @@ require_once __DIR__.'/../lib/bericht.lib.php';
header('Content-Type: application/json; charset=utf-8'); header('Content-Type: application/json; charset=utf-8');
// Output-Buffer: jeder PHP-Notice/Warning landet sonst mitten im JSON
// und macht es auf dem Client unparsebar ("Server-Fehler (kein JSON)").
if (!ob_get_level()) ob_start();
function bericht_ajax_fail($msg, $code = 400) function bericht_ajax_fail($msg, $code = 400)
{ {
while (ob_get_level()) ob_end_clean();
http_response_code($code); http_response_code($code);
echo json_encode(array('success' => false, 'error' => $msg)); echo json_encode(array('success' => false, 'error' => $msg));
exit; exit;
@ -29,10 +34,30 @@ function bericht_ajax_fail($msg, $code = 400)
function bericht_ajax_ok($data = array()) function bericht_ajax_ok($data = array())
{ {
// Verworfenen Output aus ob_start() wegwerfen, nur unser JSON rausschicken
while (ob_get_level() > 1) ob_end_clean();
$trash = ob_get_clean();
if ($trash && getenv('BERICHT_DEBUG')) error_log('[bericht-ajax] verworfener Output: '.substr($trash, 0, 500));
echo json_encode(array_merge(array('success' => true), $data)); echo json_encode(array_merge(array('success' => true), $data));
exit; exit;
} }
// Fatal-Handler: wenn etwas im PDF-Pfad explodiert, trotzdem JSON zurückgeben
register_shutdown_function(function () {
$err = error_get_last();
if ($err && in_array($err['type'], array(E_ERROR, E_PARSE, E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR), true)) {
while (ob_get_level()) ob_end_clean();
if (!headers_sent()) {
header('Content-Type: application/json; charset=utf-8');
http_response_code(500);
}
echo json_encode(array(
'success' => false,
'error' => 'PHP Fatal: '.$err['message'].' @ '.basename($err['file']).':'.$err['line'],
));
}
});
// Token-Check // Token-Check
if (!isset($_REQUEST['token']) || $_REQUEST['token'] !== newToken() && $_REQUEST['token'] !== $_SESSION['token']) { if (!isset($_REQUEST['token']) || $_REQUEST['token'] !== newToken() && $_REQUEST['token'] !== $_SESSION['token']) {
// Dolibarr-Standard erlaubt aktuellen Token; einfache Prüfung: // Dolibarr-Standard erlaubt aktuellen Token; einfache Prüfung:

View file

@ -52,8 +52,13 @@ if ($fpdi_loaded && class_exists('BerichtPdfFpdi')) {
$pdf->SetCreator('Dolibarr Bericht-Modul'); $pdf->SetCreator('Dolibarr Bericht-Modul');
$pdf->SetAuthor($user->getFullName($langs)); $pdf->SetAuthor($user->getFullName($langs));
$pdf->SetTitle($bericht->titel ?: $bericht->ref); $pdf->SetTitle($bericht->titel ?: $bericht->ref);
$logo_path = !empty($mysoc->logo) ? $conf->mycompany->dir_output.'/logos/'.$mysoc->logo : ''; global $mysoc;
$pdf->berichtInit($bericht->titel ?: $bericht->ref, $mysoc->name ?? '', $logo_path); $logo_path = '';
if (!empty($mysoc->logo) && isset($conf->mycompany->dir_output)) {
$logo_path = $conf->mycompany->dir_output.'/logos/'.$mysoc->logo;
if (!file_exists($logo_path)) $logo_path = '';
}
$pdf->berichtInit($bericht->titel ?: $bericht->ref, (isset($mysoc) && !empty($mysoc->name)) ? $mysoc->name : '', $logo_path);
$pdf->SetMargins(10, 30, 10); $pdf->SetMargins(10, 30, 10);
$pdf->SetAutoPageBreak(true, 16); $pdf->SetAutoPageBreak(true, 16);
$pdf->setPrintHeader(true); $pdf->setPrintHeader(true);

View file

@ -62,8 +62,13 @@ if ($fpdi_loaded && class_exists('BerichtPdfFpdi')) {
$pdf->SetCreator('Dolibarr Bericht-Modul (Vorschau)'); $pdf->SetCreator('Dolibarr Bericht-Modul (Vorschau)');
$pdf->SetAuthor($user->getFullName($langs)); $pdf->SetAuthor($user->getFullName($langs));
$pdf->SetTitle(($bericht->titel ?: $bericht->ref).' [Vorschau]'); $pdf->SetTitle(($bericht->titel ?: $bericht->ref).' [Vorschau]');
$logo_path = !empty($mysoc->logo) ? $conf->mycompany->dir_output.'/logos/'.$mysoc->logo : ''; global $mysoc;
$pdf->berichtInit($bericht->titel ?: $bericht->ref, $mysoc->name ?? '', $logo_path); $logo_path = '';
if (!empty($mysoc->logo) && isset($conf->mycompany->dir_output)) {
$logo_path = $conf->mycompany->dir_output.'/logos/'.$mysoc->logo;
if (!file_exists($logo_path)) $logo_path = '';
}
$pdf->berichtInit($bericht->titel ?: $bericht->ref, (isset($mysoc) && !empty($mysoc->name)) ? $mysoc->name : '', $logo_path);
$pdf->SetMargins(10, 30, 10); $pdf->SetMargins(10, 30, 10);
$pdf->SetAutoPageBreak(true, 16); $pdf->SetAutoPageBreak(true, 16);
$pdf->setPrintHeader(true); $pdf->setPrintHeader(true);